Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the owner:group of the one downloading the tarball #2303

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Mar 20, 2024

  1. Keep the owner:group of the one downloading the tarball

    In the scenario:
    ./configure --prefix=<something_which_needs_su/sudo>
    make domserver <as unpriviliged user which downloaded the tarball>
    sudo make-installdomserver <as root>
    
    We would copy the Nelmiodoc files as root, so the user can't run a make
    {dist}clean without errors as we can't remove the folder as its owned by
    root.
    
    We now also install nelmiodoc together with composer in the base image
    for CI:
    - together with the needed dependencies
    - make sure we get an autoload.php
    vmcj committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6e0a9b2 View commit details
    Browse the repository at this point in the history
  2. Try to handle the nitpick

    See
    DOMjudge#2303 (comment)
    for the reasoning behind this.
    vmcj committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    253bf14 View commit details
    Browse the repository at this point in the history
  3. Replace phony copy-bundle-assets target by a real one

    This makes that we don't rerun the rule during
    `domserver-install` if it already ran during `domserver`, so
    that if you install as root, the local files are still owned
    by the user who first ran `make domserver`, not root.
    
    This does assume that if the directory `public/bundles/nelmioapidoc`
    exists, then it contains the assets, and these won't automatically
    get updated, for example, in the setting of a maintainer-install.
    eldering authored and vmcj committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7c157f6 View commit details
    Browse the repository at this point in the history
  4. And dependency back

    vmcj committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    570c856 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    cb2c984 View commit details
    Browse the repository at this point in the history