Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WQP services (issue #35) #36

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Conversation

jbousquin
Copy link
Contributor

@jbousquin jbousquin commented Aug 12, 2021

  1. Implemented the seven services outlined in issue WQP TODO: implement other services like Organization, Activity, etc. #35 via brute force (7 new functions in wqp.py) following structure of what_sites().
  2. Updated base_url in wqp.wqp_url() to include data/, appears the existing services were being redirected to this base_url but new services did not. This should be more robust than adding 'data/' only to the new functions.
  3. Added tests to wqp_test.py for each of the new functions following test_what_sites(), and updated request_url for pre-existing functions to == md.url.
  4. Added appropriate text files for test results to data folder. The results for test_what_activities() are rather large, consider different query parameters.

… redirected properly this is the full WQP base url and other data tables were not redirected properly.
… test_get_ratings() and test_what_sites() to pass md.url assert and reflect updated base_url.
@thodson-usgs thodson-usgs merged commit ebfabab into DOI-USGS:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants