Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in noproj to remove persistent temporary lbl file #5578

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Bug fix in noproj to remove persistent temporary lbl file #5578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6a60a4
Added line to close match cube in noproj.cpp. Not closing the cube re…
kledmundson Aug 7, 2024
2a598d7
CHANGELOG entry for noproj bug fix. Addresses #5577.
kledmundson Aug 7, 2024
2a3d7e9
Added history entry in noproj.xml. Addresses #5577.
kledmundson Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ release.
- Pinned `suitesparse` dependency version to maximum not including 7.7.0 [#5496](https://github.com/DOI-USGS/ISIS3/issues/5496)

### Fixed
- Fixed a bug in noproj.cpp which left a persisent lbl file after running noproj. [#5577] (https://github.com/DOI-USGS/ISIS3/issues/5577)
- Fixed a bug in QVIEW's FindTool in which camera was prioritized over projction [#5508](https://github.com/DOI-USGS/ISIS3/issues/5508)
- Fixed a bug in PolygonTools in which the program exited before attempting to fix an invalid Polygon [#5520](https://github.com/DOI-USGS/ISIS3/issues/5520)
- Fixed a bug in QVIEW's Stretch tool where the default min/max type was not an available option [#5289](https://github.com/DOI-USGS/ISIS3/issues/5289)
Expand Down
3 changes: 2 additions & 1 deletion isis/src/base/apps/noproj/noproj.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ namespace Isis {
Cube matchCube;
matchCube.open(matchCubeFile.expanded(), "rw");
cam2cam(icube, &matchCube, cam2camUI);

matchCube.close();

// Cleanup by deleting the match files
QStringList detfiles = findAllDetachedFiles( label );
detfiles.append(matchLbl);
Expand Down
4 changes: 4 additions & 0 deletions isis/src/base/apps/noproj/noproj.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@
<change name="Ken Edmundson" date="2024-01-09">
Incorporated Kris Becker's 2021-09-22 bug fix above into USGS code base.
</change>
<change name="Ken Edmundson" date="2024-08-07">
Additional bug fix to address persistent temporary lbl file after
running noproj. Fixes #5577.
</change>
</history>

<category>
Expand Down