Geos 3.12 Update #5361
Merged
Geos 3.12 Update #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Good you folks updated embree. I ran into problems in the Mac with that one too before. Embree 2 was old. |
|
@oleg-alexandrov Some of the initial changes, still working out the kinks |
amystamile-usgs
approved these changes
Dec 7, 2023
chkim-usgs
pushed a commit
to chkim-usgs/ISIS3
that referenced
this pull request
Nov 26, 2024
* Geos changes from updating to 3.12 * Added missing float include * Updated tests * Cleaned up environment.yml * Removed pdal dep * Set geos dep to proper version * Embree3 update * Final changes to embree shape/target * Use find package shipped with embree and link against embree target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second attempt at the geos 3.12 update. #5350 was reverted due to issue with build on mac. Embree2 shipped with a some version of tbb. Other dependencies on geos 3.12 needed tbb 2021.10.0. When that version of tbb would get installed it would clobber Embree2's version of tbb and result in missing symbols. This PR has everything from the other geos PR and includes the initial steps to update to embree3. All of the calls have been changed over but we have failing tests.
Related Issue
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: