Skip to content

Commit

Permalink
Bug fix in noproj to remove persistent temporary lbl file (#5578)
Browse files Browse the repository at this point in the history
* Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses #5577.

* CHANGELOG entry for noproj bug fix. Addresses #5577.

* Added history entry in noproj.xml. Addresses #5577.
  • Loading branch information
kledmundson authored Aug 13, 2024
1 parent 33ea3f7 commit 3b879d0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ release.
- Pinned `suitesparse` dependency version to maximum not including 7.7.0 [#5496](https://github.com/DOI-USGS/ISIS3/issues/5496)

### Fixed
- Fixed a bug in noproj.cpp which left a persisent lbl file after running noproj. [#5577] (https://github.com/DOI-USGS/ISIS3/issues/5577)
- Fixed a bug in QVIEW's FindTool in which camera was prioritized over projction [#5508](https://github.com/DOI-USGS/ISIS3/issues/5508)
- Fixed a bug in PolygonTools in which the program exited before attempting to fix an invalid Polygon [#5520](https://github.com/DOI-USGS/ISIS3/issues/5520)
- Fixed a bug in QVIEW's Stretch tool where the default min/max type was not an available option [#5289](https://github.com/DOI-USGS/ISIS3/issues/5289)
Expand Down
3 changes: 2 additions & 1 deletion isis/src/base/apps/noproj/noproj.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ namespace Isis {
Cube matchCube;
matchCube.open(matchCubeFile.expanded(), "rw");
cam2cam(icube, &matchCube, cam2camUI);

matchCube.close();

// Cleanup by deleting the match files
QStringList detfiles = findAllDetachedFiles( label );
detfiles.append(matchLbl);
Expand Down
4 changes: 4 additions & 0 deletions isis/src/base/apps/noproj/noproj.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@
<change name="Ken Edmundson" date="2024-01-09">
Incorporated Kris Becker's 2021-09-22 bug fix above into USGS code base.
</change>
<change name="Ken Edmundson" date="2024-08-07">
Additional bug fix to address persistent temporary lbl file after
running noproj. Fixes #5577.
</change>
</history>

<category>
Expand Down

0 comments on commit 3b879d0

Please sign in to comment.