Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-task.py should exit with correct code #27

Merged

Conversation

yifanfu
Copy link
Contributor

@yifanfu yifanfu commented Mar 19, 2024

We are having the issue where task exit with non zero value but the script still exit with code 0. I believe this isn't the correct behaviour as in most of case we need to fail the pipeline if the task is failed. If somehow developers need to keep the pipeline running they should catch that exit code and continue.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@lzrocha lzrocha self-assigned this Mar 20, 2024
@lzrocha lzrocha self-requested a review March 20, 2024 01:38
Copy link
Contributor

@lzrocha lzrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking the time @yifanfu

@lzrocha lzrocha merged commit fd13e48 into DNXLabs:master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants