Refactoring - update scripts to python

[lgothelipe]

Update ecs-deploy image to use python scripts as standard
Currently the image has a mix of bash and python scripts

Breaking changes

Script names changing from *.sh to *.py after command key.

Example:

from:

  db-migration:
    image: public.ecr.aws/dnxsolutions/ecs-deploy:2.3.1
    env_file:
      - .env
    command: /work/run-task.sh
    volumes:
      - ./task-definition-migration.tpl.json:/work/task-definition.tpl.json
      - ./app-spec.tpl.json:/work/app-spec.tpl.json

to:

  db-migration:
    image: public.ecr.aws/dnxsolutions/ecs-deploy:latest
    env_file:
      - .env
    command: /work/run-task.py
    volumes:
      - ./task-definition-migration.tpl.json:/work/task-definition.tpl.json
      - ./app-spec.tpl.json:/work/app-spec.tpl.json

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING.md doc.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[brunodasilvalenga]

Hey @lgothelipe is there a need to have the templates inside of the docker as it should come from outside?

[brunodasilvalenga]

Otherwise, it looks good to approve!
Let's create a draft release so we can test it with some customers and see how it goes!
As soon as you create the draft release, talk with someone from the MS so we could test it in a staging environment from one of our customers.

[lgothelipe]

Hey @lgothelipe is there a need to have the templates inside of the docker as it should come from outside?

The app-spec.tpl.json file is being copied to the container to keep backward compatibility.

[brunodasilvalenga]

@lgothelipe looks good to be merged! Could you create a new version and increase the number following the semantic pattern?