Skip to content

feat(stage3eme): ajout metier proposé resultats recherche #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

Naorid
Copy link
Contributor

@Naorid Naorid commented Jan 24, 2024

No description provided.

@Naorid Naorid marked this pull request as ready for review January 24, 2024 15:01
@gmoocto gmoocto self-assigned this Jan 25, 2024
@@ -61,6 +61,7 @@ function ResultatStage3eEt2de(stage3eEt2de: Stage3eEt2de) {
sousTitreOffre={<>
<p>{stage3eEt2de.domaine}</p>
<p>{stage3eEt2de.adresse.rueEtNumero}, {stage3eEt2de.adresse.codePostal} {stage3eEt2de.adresse.ville}</p>
<p>{stage3eEt2de.appellationLibelle.map((appellationLibelle) => appellationLibelle).join(', ')}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me chagrinait de ne pas voir de liste alors j'ai testé avec 😄
Il faut un peu de CSS mais voici la proposition :

Suggested change
<p>{stage3eEt2de.appellationLibelle.map((appellationLibelle) => appellationLibelle).join(', ')}</p>
<ul className={styles.listeMetier}>{stage3eEt2de.appellationLibelle.map((appellationLibelle) => <li key={appellationLibelle}><p>{appellationLibelle}</p></li>)}</ul>

CSS :

.listeMetier {
  list-style-type: none;

  > li {
    display: inline;

    > p {
      display: inline;
    }
  }

  > li::before {
    content: ', ';
  }
  > li:first-of-type::before{
    content: none;
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 oke bien vu 👍

@gmoocto
Copy link
Contributor

gmoocto commented Jan 25, 2024

J'ai mis un message ici pour voir si on ajouterait pas un petit espacement supplémentaire, à voir :
https://mattermost.fabrique.social.gouv.fr/dnum-1j1s/pl/rxqm8mnt9pdz981s9buo153qyh

@Naorid Naorid force-pushed the feat/UNJ1S-1910-Afficher-la-liste-des-m-tiers-propos-s branch from 7a0d4c3 to 7a76c51 Compare January 26, 2024 16:50
@Naorid Naorid merged commit 481ccc6 into main Jan 30, 2024
@Naorid Naorid deleted the feat/UNJ1S-1910-Afficher-la-liste-des-m-tiers-propos-s branch January 30, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants