Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fix for GitHub Issues activity errors and resolved target/build/deploy/package issues #64

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

david-poindexter
Copy link
Contributor

Resolves #63

In addition, this PR updates the target framework and upgrades Octokit from 0.32.0 to 10.0.0 (yes, this project was that far behind). As a result of the Octokit update, various build/deploy/package issues were discovered. These are addressed in this PR.

@david-poindexter david-poindexter added the bug Something isn't working label Mar 9, 2024
@david-poindexter david-poindexter added this to the 1.4.0 milestone Mar 9, 2024
@david-poindexter david-poindexter requested a review from valadas March 9, 2024 22:47
@david-poindexter david-poindexter self-assigned this Mar 9, 2024
Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the comments I posted

Dnn.CommunityMetrics.dnn Show resolved Hide resolved
build/Build.cs Show resolved Hide resolved
Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit 422c80a into DNNCommunity:develop Mar 9, 2024
2 checks passed
@david-poindexter david-poindexter deleted the gh-issues-bug branch March 9, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Issues metrics are no longer working
2 participants