Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readabiliy of main text #99

Merged
merged 4 commits into from
Nov 22, 2020

Conversation

Timo-Breumelhof
Copy link
Collaborator

Changed body color to #000000
#98

Related to Issue

Fixes #98

Description

I changed

$font-color: #4a4a4a !default;
to
$font-color: #000000 !default;

How Has This Been Tested?

On my local machine and by editing the CSS in the browser for the live site

Screenshots (if appropriate):

See issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Changed body color to #000000
DNNCommunity#98
@Timo-Breumelhof
Copy link
Collaborator Author

Timo-Breumelhof commented Nov 16, 2020

@parasdaryanani I general I agree with that, but in this case a font weight of 200 is used, hence the #000000 (it will look less black because of the font weight)

@david-poindexter
Copy link
Collaborator

From an accessibility perspective, with black/white it is about contrast and anything above 55% black is acceptable. That said, I think a shade like #1a1a1a would look better and still be in an acceptable contrast range. #000 is fine too, but @Timo-Breumelhof may have discovered a bigger problem with the 200 default weight. Perhaps we increase the font weight (needs testing) and see how #1a1a1a looks?

@Timo-Breumelhof if you don't have time, I can probably knock this out later today or tomorrow.

To prepare for the next release and subsequent publishing to the community site, I am going to take care of a few more PRs too.

Thanks!

@david-poindexter david-poindexter added this to the 1.1.0 milestone Nov 22, 2020
@david-poindexter david-poindexter added the enhancement New feature or request label Nov 22, 2020
Copy link
Collaborator

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Timo-Breumelhof 🎉

@david-poindexter david-poindexter merged commit ee1f072 into DNNCommunity:master Nov 22, 2020
@Timo-Breumelhof Timo-Breumelhof deleted the patch-2 branch August 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Body color to #000000 for readability
3 participants