Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Theme version will be 02.00.01 as discusses with David #149

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Timo-Breumelhof
Copy link
Collaborator

@david-poindexter I still had 02.00.02 as the version, changed that to 02.00.01 as discussed previously

@Timo-Breumelhof Timo-Breumelhof self-assigned this Mar 26, 2024
@Timo-Breumelhof Timo-Breumelhof added this to the 2.0.1 milestone Mar 26, 2024
@david-poindexter david-poindexter merged commit 4a303e8 into DNNCommunity:develop Mar 28, 2024
1 check passed
@david-poindexter
Copy link
Collaborator

Thanks @Timo-Breumelhof - just let me know when you are ready for a release.

@Timo-Breumelhof
Copy link
Collaborator Author

@david-poindexter The Theme is on staging for testing ATM. I'll let you know when that's done

@Timo-Breumelhof
Copy link
Collaborator Author

@david-poindexter tested on staging and now installed on live, we can release 02.00.01

@david-poindexter
Copy link
Collaborator

@Timo-Breumelhof the release is HERE. You can edit the release, upload the theme install package, and save.

In the future, I recommend a few small tweaks to the workflow.

  1. Use the install package from latest develop branch or pull request build (ideally this should be automated using GitHub Actions) to test locally and/or on "staging".
  2. If good, release on GitHub and upload the install package to the new release.
  3. Use the install package from the new release to deploy to "production".

Following this, or a similar workflow, will ensure no manual file manipulation occurs on "staging" or "production". If manual file manipulation occurs but isn't accounted for in the GitHub source code and/or build process to generate the theme, then essentially problems with ongoing maintenance will occur (especially if it is someone else needed to do said maintenance).

Thanks for all the great work!

@Timo-Breumelhof
Copy link
Collaborator Author

Package uploaded

@david-poindexter
Copy link
Collaborator

Great - thanks @Timo-Breumelhof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants