Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/141 blog module detail width #146

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Feature/141 blog module detail width #146

merged 3 commits into from
Mar 8, 2024

Conversation

Timo-Breumelhof
Copy link
Collaborator

@Timo-Breumelhof Timo-Breumelhof commented Mar 4, 2024 •
edited
Loading

I discussed this issue with @donker and there is no solution for this issue in the Blog Module so I added styling specifically for the blog module detail view.

  • Created an extra skin Layout for this (blog.ascx) with limited panes
  • StyleHelper will inject a class when we are on the blog detail "page"
  • Added CSS to force the pane width to 100% in that case
  • Changed the detail image width in the blog template as they were too narrow
    fixes Blog module detail should be full width #141

@Timo-Breumelhof Timo-Breumelhof added the enhancement New feature or request label Mar 4, 2024
@Timo-Breumelhof Timo-Breumelhof added this to the 2.0.1 milestone Mar 4, 2024
@Timo-Breumelhof Timo-Breumelhof self-assigned this Mar 4, 2024
@david-poindexter david-poindexter merged commit e30232e into DNNCommunity:develop Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees

@Timo-Breumelhof Timo-Breumelhof

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

Blog module detail should be full width
2 participants
@Timo-Breumelhof @david-poindexter