Fixes an issue with search indexing and timezones #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search indexing uses utc times and the module was simply saving using the local webserver timezone. This PR adjusts the module in a few key ways: - Times in the database are saved using UTC times - Displayed times for users (templates) will try to use the user local time zone, if that fails it will fallback to the portal settings timezone and if that fails it will show the utc time. - In editing, it always uses the current portal timezone and it formats it using the current user prefered locale.
| userPreferredCulture = new CultureInfo(user.Profile.PreferredLocale); | ||
| } | ||
|
|
||
| ctlAudit.CreatedDate = TimeZoneInfo.ConvertTimeFromUtc(Model.AnnouncementInfo.CreatedOnDate, ModuleContext.PortalSettings.TimeZone).ToString(userPreferredCulture); |
There was a problem hiding this comment.
I think this should be utc or portal time for the audit
There was a problem hiding this comment.
Yep, it is in the portal preferred timezone but formatted in the current user culture, makes sense or I misenterpreted your comment ?
david-poindexter
requested changes
Sep 4, 2020
There was a problem hiding this comment.
Looks good @valadas - I'm sure this was fun to track down! 😆
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
Co-authored-by: David Poindexter <[email protected]>
mitchelsellers
approved these changes
Sep 5, 2020
| userPreferredCulture = new CultureInfo(user.Profile.PreferredLocale); | ||
| } | ||
|
|
||
| ctlAudit.CreatedDate = TimeZoneInfo.ConvertTimeFromUtc(Model.AnnouncementInfo.CreatedOnDate, ModuleContext.PortalSettings.TimeZone).ToString(userPreferredCulture); |
Yeah, it was real fun, I love timezones (NOT), why could'nt we all just use the same time, I already wake up at 2pm and go to bed at 5 am anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
Fixes #59 and prevents marking the module last modified date when only changing settings.
Changes made
PR Template Checklist