Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up blog page css #2121

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Clean up blog page css #2121

merged 1 commit into from
Jan 15, 2023

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 10, 2023

Visible changes:

  • Blog sidebar became slightly narrower.
  • "RSS / Atom" is moved up 0.25em.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Base: 46.67% // Head: 46.67% // No change to project coverage 👍

Coverage data is based on head (6c6ae6f) compared to base (44fc069).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   46.67%   46.67%           
=======================================
  Files         239      239           
  Lines       13250    13250           
=======================================
  Hits         6185     6185           
  Misses       7065     7065           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xyene
Copy link
Member

Xyene commented Jan 13, 2023

Could you please attach some screenshots?

@int-y1
Copy link
Contributor Author

int-y1 commented Jan 13, 2023

Could you please attach some screenshots?

Before:
1

After:
2

@Xyene
Copy link
Member

Xyene commented Jan 13, 2023

Before, the contents of ongoing contests / comment stream / new problems had the same amount of left margin (roughly matching the amount of top margin), while now only the comment stream and new problems do.

@int-y1
Copy link
Contributor Author

int-y1 commented Jan 15, 2023

Reverted flexbox ratios. Now, the only visible change is "RSS / Atom".

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit c01daec into DMOJ:master Jan 15, 2023
@int-y1 int-y1 deleted the blog-css branch January 15, 2023 06:12
@int-y1 int-y1 mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants