Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ContestCalendar css #2036

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Clean up ContestCalendar css #2036

merged 1 commit into from
Nov 14, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Nov 14, 2022

  • weekday_classes is useless. It only affects <th>, but no <th> uses it.
  • No need for border-right/left/bottom. border is enough because of border-collapse: collapse;.

New version of ContestCalendar:

Capture

@codecov-commenter
Copy link

Codecov Report

Base: 46.48% // Head: 46.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d4c87f0) compared to base (67cdfbe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2036   +/-   ##
=======================================
  Coverage   46.48%   46.48%           
=======================================
  Files         236      236           
  Lines       13089    13082    -7     
=======================================
- Hits         6084     6081    -3     
+ Misses       7005     7001    -4     
Impacted Files Coverage Δ
judge/views/contests.py 29.10% <100.00%> (-0.14%) ⬇️
judge/utils/views.py 39.24% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 36c95c3 into DMOJ:master Nov 14, 2022
@int-y1 int-y1 deleted the cc-css branch November 14, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants