Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comments work again on Django 3.2 #2016

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Make comments work again on Django 3.2 #2016

merged 1 commit into from
Oct 30, 2022

Conversation

quantum5
Copy link
Member

No description provided.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Base: 46.50% // Head: 46.53% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5ae6f47) compared to base (b676a49).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
+ Coverage   46.50%   46.53%   +0.02%     
==========================================
  Files         236      236              
  Lines       13104    13124      +20     
==========================================
+ Hits         6094     6107      +13     
- Misses       7010     7017       +7     
Impacted Files Coverage Δ
judge/comments.py 40.86% <50.00%> (ø)
judge/utils/raw_sql.py 30.26% <50.00%> (+0.41%) ⬆️
judge/widgets/select2.py 60.39% <0.00%> (+3.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xyene Xyene merged commit 3c7456a into master Oct 30, 2022
@Xyene Xyene deleted the fix-comments branch October 30, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants