Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless "set title" #1924

Merged
merged 1 commit into from
May 20, 2022
Merged

Remove useless "set title" #1924

merged 1 commit into from
May 20, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Apr 18, 2022

Remove uses of set title that break i18n. Affected pages:

/contests/
/organizations/
/problems/
/stats/language/
/users/

@codecov-commenter
Copy link

Codecov Report

Merging #1924 (c7f2b5c) into master (70cc14b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1924   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files         235      235           
  Lines       13107    13107           
=======================================
  Hits         6084     6084           
  Misses       7023     7023           
Impacted Files Coverage Δ
judge/models/submission.py 90.50% <ø> (ø)
judge/views/stats.py 45.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cc14b...c7f2b5c. Read the comment docs.

@quantum5 quantum5 merged commit 9ba005b into DMOJ:master May 20, 2022
@int-y1 int-y1 deleted the fix-more-titles branch May 20, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants