Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n in fields #1897

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix i18n in fields #1897

merged 2 commits into from
Mar 21, 2022

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Mar 19, 2022 

git grep "verbose_name=[^_]"
git grep "help_text=[^_]"

Ninjaclasher
Ninjaclasher approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

quantum5
quantum5 reviewed Mar 20, 2022
View reviewed changes
judge/models/runtime.py Outdated Show resolved Hide resolved
@int-y1 @quantum5
Update judge/models/runtime.py
ec6b5b5 
Co-authored-by: Guanzhong Chen <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1897 (ec6b5b5) into master (65bc1fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1897   +/-   ##
=======================================
  Coverage   46.24%   46.25%           
=======================================
  Files         231      231           
  Lines       13054    13045    -9     
=======================================
- Hits         6037     6034    -3     
+ Misses       7017     7011    -6
Impacted Files Coverage Δ
judge/models/contest.py 96.20% <100.00%> (ø)
judge/models/runtime.py 70.79% <100.00%> (ø)
judge/utils/pwned.py 39.02% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bc1fe...ec6b5b5. Read the comment docs.

@quantum5 quantum5 merged commit 15a1982 into DMOJ:master Mar 21, 2022
@int-y1 int-y1 deleted the fix-field-i18n branch March 22, 2022 04:06
hieplpvip pushed a commit to VNOI-Admin/OJ that referenced this pull request Apr 17, 2022
@int-y1 @quantum5 @hieplpvip
Fix i18n in fields (DMOJ/online-judge#1897)
26d7e2a 
Co-authored-by: Quantum <[email protected]>
hieplpvip pushed a commit to VNOI-Admin/OJ that referenced this pull request Apr 20, 2022
@int-y1 @quantum5 @hieplpvip
Fix i18n in fields (DMOJ/online-judge#1897)
5eb22b3 
Co-authored-by: Quantum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ninjaclasher Ninjaclasher Ninjaclasher approved these changes

@quantum5 quantum5 quantum5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@int-y1 @codecov-commenter @quantum5 @Ninjaclasher