Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contest curator and testers #1668

Merged
merged 7 commits into from
May 7, 2021
Merged

Add contest curator and testers #1668

merged 7 commits into from
May 7, 2021

Conversation

kiritofeng
Copy link
Member

@kiritofeng kiritofeng commented May 6, 2021

Fixes #1556.

@kiritofeng kiritofeng changed the title Add contest currator and testers Add contest curator and testers May 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #1668 (7b841c6) into master (61145c5) will increase coverage by 0.15%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   46.25%   46.40%   +0.15%     
==========================================
  Files         215      216       +1     
  Lines       12282    12347      +65     
==========================================
+ Hits         5681     5730      +49     
- Misses       6601     6617      +16     
Impacted Files Coverage Δ
judge/admin/contest.py 44.73% <0.00%> (ø)
.../migrations/0110_default_output_prefix_override.py 100.00% <ø> (ø)
judge/models/tests/util.py 97.65% <ø> (ø)
judge/views/api/api_v2.py 47.58% <0.00%> (-0.20%) ⬇️
judge/views/submission.py 32.66% <0.00%> (ø)
judge/views/contests.py 30.05% <10.00%> (-0.10%) ⬇️
...udge/migrations/0116_contest_curator_and_tester.py 100.00% <100.00%> (ø)
judge/models/contest.py 95.71% <100.00%> (+0.21%) ⬆️
judge/models/tests/test_contest.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61145c5...7b841c6. Read the comment docs.

@kiritofeng
Copy link
Member Author

Obligatroy speling iz harrd

@kiritofeng kiritofeng requested a review from quantum5 May 6, 2021 04:35
@kiritofeng kiritofeng requested a review from quantum5 May 6, 2021 06:08
@kiritofeng
Copy link
Member Author

Removed Contest.object.is_editor(...) entirely, and replaced all instances with ... in editor_ids instead.

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems obviously broken to me.

@kiritofeng kiritofeng force-pushed the contest-currator branch 3 times, most recently from 0a571c9 to 3d12093 Compare May 7, 2021 02:30
@kiritofeng kiritofeng requested a review from Ninjaclasher May 7, 2021 02:32
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@kiritofeng kiritofeng requested a review from Ninjaclasher May 7, 2021 03:05
@kiritofeng kiritofeng merged commit cac63d9 into master May 7, 2021
@kiritofeng kiritofeng deleted the contest-currator branch May 7, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contest tester field
4 participants