Switch from pyotp to secrets for generating backup 2FA tokens #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
reviewed
Feb 12, 2021
quantum5
reviewed
Feb 12, 2021
fluix-dev
force-pushed
the
fix-otp-gen
branch
from
36fe069
to
c8ddcc6
Compare
pyotp recently released a new version[1] which changes the minimum length of base32 secret generation to 32 characters. [1]: https://github.com/pyauth/pyotp/releases/tag/v2.6.0
quantum5
approved these changes
Feb 12, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyotp recently released a new version1 which changes the minimum
length of base32 secret generation to 32 characters.