Remove superuser optimizations for most recent comments #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimization does not work with the current caching of comment titles, and masks potential performance issues.
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
+ Coverage 37.92% 37.94% +0.01%
==========================================
Files 198 198
Lines 11337 11341 +4
==========================================
+ Hits 4300 4303 +3
- Misses 7037 7038 +1
Continue to review full report at Codecov.
|
Xyene
approved these changes
Jun 3, 2020
outloudvi
pushed a commit
to SchOJ/site
that referenced
this pull request
Oct 27, 2020
This optimization does not work with the current caching of comment titles, and masks potential performance issues.
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
This optimization does not work with the current caching of comment titles, and masks potential performance issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization does not work with the current caching of comment titles, and masks potential performance issues.