Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment access check for problem solutions is incorrect #1371

Closed
Ninjaclasher opened this issue May 7, 2020 · 0 comments · Fixed by #1425
Closed

Comment access check for problem solutions is incorrect #1371

Ninjaclasher opened this issue May 7, 2020 · 0 comments · Fixed by #1425
Labels
bug security

Comments

@Ninjaclasher
Copy link
Member

Ninjaclasher commented May 7, 2020 •
edited
Loading

The current comment access check for problem solutions assumes that if you can see comments on the problem, you can also see comments on the problem solution. However, this is not the case for private problem solutions but public problems.
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
03ecb03
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
c8b7afa
@Ninjaclasher Ninjaclasher mentioned this issue Jun 4, 2020
Merged
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
e026f4e
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
ab9ab0c
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
339844b
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 4, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
12fb400
Xyene pushed a commit that referenced this issue Jun 6, 2020
@Ninjaclasher @Xyene
Fix problem solution access check; fixes #1371
e1e2a3e
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Jun 7, 2020
@Ninjaclasher
Fix problem solution access check; fixes DMOJ#1371
fe445e0
outloudvi pushed a commit to SchOJ/site that referenced this issue Oct 27, 2020
@Ninjaclasher @outloudvi
Fix problem solution access check; fixes DMOJ#1371
c89174c
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Ninjaclasher @Xyene
Fix problem solution access check; fixes DMOJ#1371
e6ea1c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix problem solution access check; fixes #1371 Ninjaclasher/site
2 participants
@Xyene @Ninjaclasher