Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Atari envs version #865

Closed
wants to merge 3 commits into from
Closed

Conversation

carlosluis
Copy link
Contributor

Description

Bump version of Atari envs to match the latest in Gym (and Ale-py).

Motivation and Context

Keeping up-to-date with latest changes in Atari envs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member

araffin commented Apr 15, 2022

Bump version of Atari envs to match the latest in Gym (and Ale-py).
Keeping up-to-date with latest changes in Atari envs.

Hello,

I think there was a misunderstanding, see #734 (comment)
and discussion in #572 (comment)

@carlosluis
Copy link
Contributor Author

I see, missed that bit of context. Then I guess these changes will only be merged once performance of v5 are properly benchmarked. Could you confirm that's the case?

If yes, then I will close this PR as I wasn't planning on doing that right now.

@araffin
Copy link
Member

araffin commented Apr 15, 2022

Then I guess these changes will only be merged once performance of v5 are properly benchmarked. Could you confirm that's the case?

There is more than that, some changes of v5 were quite arbitrary (see discussion with Jesse, starting here #572 (comment)) so I would tend to go for v4 with fixes (if that's possible), or v5 if v5 is benchmarked and compared to v4.
(I was also thinking about switching to env pool as it can be really fast for training on Atari games, but not in our tests as it would add an additional dependency)

@carlosluis
Copy link
Contributor Author

Closing as unresolved. Read comments and associated issues for context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants