Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix PPO + gSDE #53

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Hotfix PPO + gSDE #53

merged 4 commits into from
Jun 10, 2020

Conversation

araffin
Copy link
Member

@araffin araffin commented Jun 10, 2020

Description

closes #52
closes #54

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have checked the codestyle using make lint
  • I have ensured make pytest and make type both pass.

@araffin araffin requested a review from Miffyli June 10, 2020 16:11
@araffin
Copy link
Member Author

araffin commented Jun 10, 2020

@Miffyli I will merge this one as soon as the tests pass because it is a hotfix (I will also do a release on pypi).

@araffin araffin merged commit 494ebfd into master Jun 10, 2020
@araffin araffin deleted the fix/ppo branch June 10, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest fails randomly on VecNormalize tests Bug in PPO - Performance do not match gSDE paper
1 participant