-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Monitor episode reward/length for evaluate_policy
#220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some points we need to discuss ;)
CI will fail because I could not get typing stuff to work out (e.g. Monitor's). There also starts being a ton of circular imports which are suuuuuper-fun to deal with. I think making whole @araffin Could you look into the typing things if the current things are alright and fix where necessary? |
No worry, I will take a look ;) (i had some fun with that in the past) |
@Miffyli done ;) but there some warnings not catched now...
the issue is then the automatic documentation which would fail (yes it is a mess ^^#) |
Thanks a ton! Now things should be in order :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM =)
Description
Design choice: Checking for Monitor wrapper reliably for both envs and vecenvs got tricky and messy, so instead I opted for "lazily" checking if the
"episode"
information is available in info and assume it is from a Monitor wrapper.Motivation and Context
closes #181
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)