Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitlab CI #12

Merged
merged 13 commits into from
May 9, 2020
Merged

Add Gitlab CI #12

merged 13 commits into from
May 9, 2020

Conversation

araffin
Copy link
Member

@araffin araffin commented May 9, 2020

Description

Add continuous integration using Gitlab-CI.

Motivation and Context

Addresses part of #1 .

@AdamGleave
Copy link
Collaborator

Curious why you chose GitLab? I mostly use CircleCI these days and found it a big improvement on Travis but I've not tried GitLab/Azure Pipelines and some of the other new players.

@araffin
Copy link
Member Author

araffin commented May 9, 2020

Curious why you chose GitLab?

Good point, the thing is I'm in discussion with my institute admins because travis/cicle ci/codacy require additional permissions, but I wanted to setup CI as soon as possible anyway.
So, I found that Gitlab had a nice integration with Github ;)

mostly use CircleCI these days and found it a big improvement on Travis but I've not tried GitLab/Azure Pipelines and some of the other new players.

That was something I've seen and wanted to ask you, what is best? and why CircleCI?

@araffin araffin requested a review from AdamGleave May 9, 2020 20:10
@araffin
Copy link
Member Author

araffin commented May 9, 2020

@AdamGleave I will merge it as it is needed for any further PR, but we can continue the discussion here ;)

@araffin araffin merged commit 257a40e into master May 9, 2020
@araffin araffin deleted the feat/gitlab-ci branch May 9, 2020 21:10
@AdamGleave
Copy link
Collaborator

AdamGleave commented May 10, 2020

Good point, the thing is I'm in discussion with my institute admins because travis/cicle ci/codacy require additional permissions, but I wanted to setup CI as soon as possible anyway.
So, I found that Gitlab had a nice integration with Github ;)

OK, makes sense -- thanks for setting up CI.

That was something I've seen and wanted to ask you, what is best? and why CircleCI?

I like CircleCI since it easily supports parallelizing across nodes (up to 4 nodes free), and -- if you pay -- you can run on machines with more resources. This is very useful for large and slow test suites, such as if you're actually training mini-ML models as part of the suite.

It seems much more actively developed than Travis and has a better UI and generally more features.

Pipelines looks pretty nice and I've seen a few open-source projects migrate to this but I don't have any hands-on experience with it.

@araffin
Copy link
Member Author

araffin commented May 11, 2020

Pipelines looks pretty nice and I've seen a few open-source projects migrate to this but I don't have any hands-on experience with it.

Pipeline are nice but build for external PR are not automatic :/ (I need to create an internal branch that corresponds to each PR)
So I guess I will ask the admins for CircleCI integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants