Skip to content

Hercules DJControl Inpulse 200: Fix some code stye issues #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DJPhatso merged 1 commit into from
Mar 12, 2020
Merged

Hercules DJControl Inpulse 200: Fix some code stye issues #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions res/controllers/Hercules-DJControl-Inpulse-200-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ DJCi200.init = function() {
DJCi200.scratchButtonState = true;
// Scratch Action
DJCi200.scratchAction = {
1: DJCi200.kScratchActionNone,
2: DJCi200.kScratchActionNone
1: DJCi200.kScratchActionNone,
2: DJCi200.kScratchActionNone
};

//Turn On Vinyl buttons LED(one for each deck).
Expand All @@ -61,11 +61,11 @@ DJCi200.init = function() {
//Turn On Browser button LED
midi.sendShortMsg(0x90, 0x04, 0x05);

//Softtakeover for Pitch fader
engine.softTakeover("[Channel1]", "rate", true);
engine.softTakeover("[Channel2]", "rate", true);
engine.softTakeoverIgnoreNextValue("[Channel1]", "rate");
engine.softTakeoverIgnoreNextValue("[Channel2]", "rate");
//Softtakeover for Pitch fader
engine.softTakeover("[Channel1]", "rate", true);
engine.softTakeover("[Channel2]", "rate", true);
engine.softTakeoverIgnoreNextValue("[Channel1]", "rate");
engine.softTakeoverIgnoreNextValue("[Channel2]", "rate");

//Set effects Levels - Dry/Wet
engine.setParameter("[EffectRack1_EffectUnit1_Effect1]", "meta", 0.6);
Expand All @@ -77,7 +77,7 @@ DJCi200.init = function() {
engine.setParameter("[EffectRack1_EffectUnit1]", "mix", 1);
engine.setParameter("[EffectRack1_EffectUnit2]", "mix", 1);

// Ask the controller to send all current knob/slider values over MIDI, which will update
// Ask the controller to send all current knob/slider values over MIDI, which will update
// the corresponding GUI controls in MIXXX.
midi.sendShortMsg(0xB0, 0x7F, 0x7F);
};
Expand Down
4 changes: 2 additions & 2 deletions res/controllers/Hercules_DJControl_Inpulse_200.midi.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@
<normal />
</options>
</control>

<!--Continuous Controllers (CC) - Faders/knobs -->
<!-- CC's MIDI Channel 1 (0xB0 Standard mode)-->
<!--Crossfader-->
Expand Down Expand Up @@ -1645,4 +1645,4 @@
</output>
</outputs>
</controller>
</MixxxMIDIPreset>
</MixxxMIDIPreset>