Skip to content

fix(approvals): normalize routed household profile guard - #29

Merged
DIZ-admin merged 5 commits into
mainfrom
fix/household-approval-toggle-guard-routed-profile
Jul 25, 2026
Merged

fix(approvals): normalize routed household profile guard#29
DIZ-admin merged 5 commits into
mainfrom
fix/household-approval-toggle-guard-routed-profile

Conversation

@DIZ-admin

Copy link
Copy Markdown
Owner

Summary

  • normalize routed household profile fallback for approval commands
  • extend household approval guard coverage
  • add regression tests for routed profile and write-approval paths

Verification

  • branch contains the follow-up commits after the already merged approval guard
  • regression coverage is included in the branch
  • branch is clean and based on the fork main

Merge policy

This PR targets only DIZ-admin/hermes-agent:main; upstream is reference-only.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DIZ-admin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 470a6f11-542c-405c-a9f1-007126fdc704

📥 Commits

Reviewing files that changed from the base of the PR and between 2680d7a and d5b069b.

📒 Files selected for processing (3)
  • hermes_cli/write_approval_commands.py
  • tests/gateway/test_household_approval_toggle_guard.py
  • tests/tools/test_write_approval.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/household-approval-toggle-guard-routed-profile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DIZ-admin

Copy link
Copy Markdown
Owner Author

Follow-up pushed in ec24cb97e.

Hardened the approval guard to fail closed when profile identity is empty or missing. Previously approval_toggle_allowed("") returned True, which could allow an unstamped multiplexed route to inherit toggle permission.

Verification:

  • tests/gateway/test_household_approval_toggle_guard.py tests/tools/test_write_approval.py: 42 passed
  • git diff --check: passed

…l-toggle-guard-routed-profile

# Conflicts:
#	hermes_cli/write_approval_commands.py
#	tests/gateway/test_household_approval_toggle_guard.py
#	tests/tools/test_write_approval.py
@DIZ-admin
DIZ-admin merged commit c32775d into main Jul 25, 2026
36 checks passed
@DIZ-admin
DIZ-admin deleted the fix/household-approval-toggle-guard-routed-profile branch July 25, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant