perf(deps): replace psl with tldts
#790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! |
remusao
reviewed
Dec 30, 2023
| @@ -78,7 +78,7 @@ export function getPageRSSHub(data: { | |||
|
|
|||
| let parsedDomain; | |||
| try { | |||
| parsedDomain = psl.parse(new URL(url).hostname); | |||
| parsedDomain = parse(new URL(url).hostname); | |||
There was a problem hiding this comment.
Note: salesforce/tough-cookie#346 (comment)
Some of these might be relevant depending on your use-case. There are slight differences in default behavior between psl and tldts.
There was a problem hiding this comment.
Thank you so much, private domains will not be used in our extension, so there is no problem.
There was a problem hiding this comment.
If you want to shrink the bundle size a bit, there is a version of tldts that only ships with ICANN rules: https://github.com/remusao/tldts/tree/master/packages/tldts-icann#tldts---blazing-fast-url-parsing-icann-rules-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It runs fast and performant.
Returned object is similar.
Background: salesforce/tough-cookie#346