Expose icons as an option and create a new option to set icon color #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micooz
reviewed
Sep 19, 2017
src/DPlayer.js
Outdated
| @@ -33,6 +33,8 @@ class DPlayer { | |||
|
|
|||
| this.tran = new i18n(this.options.lang).tran; | |||
|
|
|||
| this.icons = new Svg(this.options); | |||
There was a problem hiding this comment.
Svg seems to represent a single svg instead of a collection of svg, maybe change it to SvgCollection or other name to make it more semantic.
|
Apart from the naming, others are LGTM. And don't forget documents for the new options. |
|
Thanks for the feedback @micooz |
DIYgod
approved these changes
Sep 19, 2017
tsukumijima
pushed a commit
to tsukumijima/DPlayer
that referenced
this pull request
Nov 21, 2019
Expose icons as an option and create a new option to set icon color
tsukumijima
added a commit
to tsukumijima/DPlayer
that referenced
this pull request
Nov 21, 2019
Expose icons as an option and create a new option to set icon color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.