[8.0] TransformationCleaningAgent: add Clean With RMS option #7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
…quests instead of direct cleanup
andresailer
force-pushed
the
80_tcaRMS
branch
from
45e7f59
to
814ecea
Compare
andresailer
commented
Sep 28, 2023
| @@ -387,6 +395,11 @@ def cleanContent(self, directory): | |||
| # Executing with shifter proxy | |||
| gConfigurationData.setOptionInCFG("/DIRAC/Security/UseServerCertificate", "false") | |||
| failed = {} | |||
| if self.cleanWithRMS: | |||
There was a problem hiding this comment.
So actually this branch (i.e., cleanContent function) is never used for me, because everything is based on meta data to find files and not on directories
|
Do you think the flag could be removed from v8.1? (and the |
Fine for me, I just thought maybe some people only have the TS but not the RMS set up so we don't mix the two systems by default, or this is considered not safe enough. |
|
RMS is necessary, an installation can't live without it. |
fstagni
approved these changes
Oct 11, 2023
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Oct 11, 2023
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/6484826852 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was implemented some time ago, when a transformation with >10k files had to be cleaned. I am not sure I exercise this logic too often...
It is completely optional, so I think OK for 8.0.
It might be a bit loose on the error handling side, which is probably why I kept it in my hot fixes branch...
It request submission is successful, the transformation is marked as cleaned.
It is not waiting for requests to succeed, if something fails one can always clean a transformation again.
So review away.
BEGINRELEASENOTES
*TS
NEW: TransformationCleaningAgent: add CleanWithRMS option to clean files via the RequestManagementSystem asynchronously rather than serially in the agent run itself
ENDRELEASENOTES