[v7r3] Replace singularity with apptainer #6440
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:rel-v8r0
fstagni
reviewed
Oct 20, 2022
Comment on lines
+39
to
+42
| if six.PY2: | ||
| assert res["SubmittedJobs"] == 0 | ||
| else: | ||
| assert res["SubmittedJobs"] == 1 |
There was a problem hiding this comment.
This is a copy and paste of the SingularityCE test so I have no idea, I defer to the original author of the change 😅 96de927#diff-3ed8e61b9808b5f01275986e1b4401914daf0ce427d6ebd4f809f695948fe43a
There was a problem hiding this comment.
AH, it must be correct then! 😄
Maybe because it's only py3? #5716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps a
SingularityComputingElementclass for backwards compatibility, though this class also usesapptainerbehind the scenes. I propose we removeSingularityComputingElementfrom v8.0.x but we can keep it until v8.1 if people prefer.Draft for now as I haven't tested it yet.
BEGINRELEASENOTES
*WorkloadManagement
NEW: Replace SingularityComputingElement with ApptainerComputingElement
ENDRELEASENOTES