[V7r3] Refactorise TaskManager #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you change anything in the logic of RequestTasks and/or WorkflowTasks, or is it a cut/paste job only? |
|
pure cut and paste and rename |
fstagni
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective was to be able to use the
ObjectLoaderonRequestTasks. However, it was not possible due to the way the code was arranged.4c9052c: split into different modules
8432ddc: use object loader
Of course, if anyone was overwriting these classes(like LHCb), they would need to adapt
@atsareg @fstagni @andresailer can you please look carefully at that, although I don't think there is any dramatic changes
BEGINRELEASENOTES
*TS
CHANGE: RequestTaskAgent uses objectLoader for RequestTasks
CHANGE: split RequestTasks and WorkflowTasks into distinct module
ENDRELEASENOTES