[v6r20] Bug fixes for pilot 3 files synchronization #3837
Conversation
| return backupsList | ||
|
|
||
| def __getPreviousCFG( self, oRemoteConfData ): | ||
| remoteExpectedVersion = oRemoteConfData.getVersion() |
There was a problem hiding this comment.
This changes the semantics. Now the version is evaluated once at the moment the function definition is processed. Previously, the version was reevaluated before each function call. And I think in this case this really matters.
There was a problem hiding this comment.
I am not sure I understand: why would it matter? I can restore it, no problem, but I would like to understand what's the reason, as remoteExpectedVersion is not used.
There was a problem hiding this comment.
Yes, you are right, I thought the subsequent call was using this variable anticipating the developer intentions. And I think this will be indeed correct to get the value into the variable and pass it to the subsequent self.__getCfgBackups(... call.
| rpcClient = self.__getRPCClient() | ||
| return rpcClient.setAssigneeGroup( groupName, userList ) | ||
|
|
||
| def getUsersInAssigneeGroup( self, groupName ): |
There was a problem hiding this comment.
You drop these methods because there are implicitly accessible through the generic client anyway ? If so, then we rather move in a different direction to specify explicitly all methods in a specific client in order to be able to specify individual timeout, for example, and also to make those methods visible at the iPython prompt.
There was a problem hiding this comment.
Yes I removed them because I am using Client as base class.
To have calls visible through iPython we should improve the Client class instead: some time ago it was tried already https://github.com/DIRACGrid/DIRAC/blob/integration/Core/Base/Client.py#L34
|
For this one: I need to update the wiki for the change in the CS locations. Let me know if you agree with what I have done (module the comment in the other module) |
|
Sorry, I have not understand the question in the previous comment "(module the comment in the other module)" ? |
|
Sorry, I was not clear: the changes in PilotCS2JSONSynchronizer need to be added in the wiki, let me know if you agree with them. |
|
Yes, I agree, please, add to the Wiki |
|
|
||
| class ServiceInterface(threading.Thread): |
There was a problem hiding this comment.
Do you really need to format this file ? Louis modified it in his PR, and this is for sure going to be a merging conflict for Andrei.
There was a problem hiding this comment.
It has been merged already...
Plus other minor fixes
BEGINRELEASENOTES
*Configuration
FIX: Corrected configuration location for Pilot 3 files synchronization
ENDRELEASENOTES