[v6r11] Some fixes for WMS #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ############################################################################## | ||
| types_getSiteMaskLogging = [ list(StringTypes)+[ListType] ] | ||
| def export_getSiteMaskLogging(self,sites): | ||
| types_getSiteMaskLogging = [ [StringTypes, ListType] ] |
There was a problem hiding this comment.
This is a bug, the previous was correct, StringTypes is a tuple
There was a problem hiding this comment.
You are right, I correct it now
|
Forget my comment about the nonzero. I overlooked your mail. |
| ) ENGINE = InnoDB; | ||
| DROP TABLE IF EXISTS `Jobs`; | ||
| CREATE TABLE `Jobs` ( | ||
| `JobID` INT(11) UNSIGNED NOT NULL DEFAULT 0, |
There was a problem hiding this comment.
@fstagni Can you confirm that this AUTO_INCREMENT was dropped on purpose
There was a problem hiding this comment.
Yes it was dropped on purpose: the "main" table is in fact JobJDLs (where AUTO_INCREMENT on JobID is maintained), not Jobs, where we have that FOREIGN KEY (JobID) REFERENCES JobJDLs(JobID),
There was a problem hiding this comment.
Thanks for the fast response and the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also changes to comply to the Data Model https://docs.python.org/2/reference/datamodel.html#object.__nonzero__ for the RMS and DMS, that was causing a real bug (RequestName was wrongly set in FailoverRequest.py)
Some (old, broken) test files for WMS DBs have been removed and are now in TestDIRAC