Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scenarios old add group by function as prop #369

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

JacobJsuh
Copy link
Contributor

This PR

Closes #xxx

Notes

Adds functionality to allow for a custom grouping by functionality instead of only by dateTime on the scenariosOLD component.

This grouping by function is added in as an optional prop by users of the component. If no prop is added it will group by dateTime.

Fulfilled the scope of this repo?

  • The same functionality of the component can not be achieved with theming, basic styling or composition of existing components
  • The component implements an element of the DHI Design Guidelines or is otherwise generic enough in functionality and close enough to the DHI CVI that it is likely to find reuse in other projects

Completness

  • Story included

@JacobJsuh JacobJsuh marked this pull request as ready for review June 12, 2024 04:17
@FranzThomsen1089 FranzThomsen1089 merged commit 37aa1c2 into master Jun 12, 2024
1 check failed
@FranzThomsen1089 FranzThomsen1089 deleted the feat/Scenarios-Old-Add-GroupBy-Function branch June 12, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants