Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor matching to be Observation type agnostic #413

Merged
merged 11 commits into from
Mar 20, 2024
Merged

Refactor matching to be Observation type agnostic #413

merged 11 commits into from
Mar 20, 2024

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Feb 5, 2024 •
edited
Loading

The goal with this PR is to move all geometry specific logic out of the matching module and into specific classes, e.g. TrackModelResult.

@ecomodeller ecomodeller changed the title Refactor mathcing to be Observation type agnostic Refactor matching to be Observation type agnostic Feb 5, 2024
@ecomodeller ecomodeller marked this pull request as ready for review February 5, 2024 12:23
jsmariegaard
jsmariegaard requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure align() does not appear in docs.

re-insert time_interp and let align() wrap time_interp().

@ecomodeller ecomodeller merged commit eab3744 into main Mar 20, 2024
11 checks passed
@ecomodeller ecomodeller deleted the obs branch March 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmariegaard jsmariegaard jsmariegaard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @jsmariegaard