-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't sort on groupby (e.g. in skill() method) #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsmariegaard
commented
Jan 4, 2024
•
edited
Loading
edited
- groupby(..., sort=False) in skill() and similar methods
- correct tests accordingly
- Fix bug in weights when assigning from dict (caused wrong results in some cases)
- Re-introduce to_dataframe() on Comparer
- Syncronize to_dataframe() of Comparer and Timeseries such that they work in the same way (include aux also)
- Docstrings for all to_dataframe() methods
- Docstrings for several other methods
- Renaming of internal variables (and variables in tests) to confirm to best practice and for consistency (e.g. sk for skill() )
- New method sort_values() on SkillTable
- xy set to nan for skill() of track data
Refactor long_dataframe
…into groupby-sort-false
Now added more tests. Okay to merge @ecomodeller ? |
Good, and I changed the |
ecomodeller
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.