Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/deprecate more properties #373

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Remove/deprecate more properties #373

merged 11 commits into from
Jan 4, 2024

Conversation

jsmariegaard
Copy link
Member

@jsmariegaard jsmariegaard commented Jan 3, 2024 •
edited
Loading

  • From observations remove geometry properties
  • From ComparerCollection remove n_comparers
  • Rename "name" to "_name" and "comparers" to "_comparers" in ComparerCollection
  • Rename unit_text to _unit_text in Comparer and ComparerCollection
  • And fix all remaining warnings in test 😃

@jsmariegaard jsmariegaard marked this pull request as ready for review January 3, 2024 15:54
@jsmariegaard jsmariegaard merged commit a2455c1 into main Jan 4, 2024
10 checks passed
@jsmariegaard jsmariegaard deleted the remove-more-properties branch January 4, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecomodeller ecomodeller ecomodeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmariegaard @ecomodeller