Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim public API; remove properties #354

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Slim public API; remove properties #354

merged 11 commits into from
Dec 20, 2023

Conversation

jsmariegaard
Copy link
Member

@jsmariegaard jsmariegaard commented Dec 20, 2023 •
edited
Loading

Removed properties:

  • Comparer
    • quantity_name
    • obs
    • mod
    • obs_name
    • _unit_text
  • TimeSeries
    • color (temporary disabled until we have better color handling)
    • plot.plot (no need for a ts.plot.plot() - it's ugly 🤢)

Apart from this lots of docstring improvements and fixing broken links in docs.

@jsmariegaard jsmariegaard marked this pull request as ready for review December 20, 2023 13:25
@jsmariegaard jsmariegaard mentioned this pull request Dec 20, 2023
Closed
@ecomodeller
Copy link
Member

  • plot.plot (no need for a ts.plot.plot() - it's ugly 🤢)

Fixed already in #347 ... just saying

@jsmariegaard jsmariegaard merged commit 543821c into main Dec 20, 2023
10 checks passed
@jsmariegaard jsmariegaard deleted the remove-properties branch December 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecomodeller ecomodeller ecomodeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmariegaard @ecomodeller