Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comparer order on save/load #346

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Preserve comparer order on save/load #346

merged 2 commits into from
Dec 19, 2023

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Dec 18, 2023

closes #345

@ecomodeller ecomodeller changed the title Failing test Preserve comparer order on save/load Dec 18, 2023
@ecomodeller ecomodeller marked this pull request as ready for review December 18, 2023 16:49
f"Input must have a datetime index! Provided index was {type(time.to_index())}"
)
return time.dt.round("100us")
if isinstance(time, pd.DatetimeIndex):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to the PR, but necessary for the simplest possible test case.

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsmariegaard jsmariegaard merged commit 75056ee into main Dec 19, 2023
10 checks passed
@jsmariegaard jsmariegaard deleted the save-order branch December 19, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save/load of ComparerCollection doesn't preserve order
2 participants