Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to SkillTable and SkillArray #324

Merged
merged 9 commits into from
Dec 13, 2023

Conversation

jsmariegaard
Copy link
Member

No description provided.

@ecomodeller
Copy link
Member

I am looking at the multivariable comparison, where not all combinations of model, observation and variable exist.

Does this behaviour make sense ,i.e selecting a list of columns or a single column?

In the first case with [["rmse"]] I don't get any missing values, whiile using ["rmse"] I do.

>>> s[["rmse"]].to_dataframe()
                                                rmse
model observation variable                         
SW_1  EPL_Hm0     Significant wave height  0.223597
      F16_wind    Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
      HKNA_wind   Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
      c2_wind     Wind speed               0.698317
SW_2  EPL_Hm0     Significant wave height  0.223597
      F16_wind    Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
      HKNA_wind   Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
      c2_wind     Wind speed               0.698317
>>> s["rmse"].to_dataframe()
                                               rmse
model observation variable                         
SW_1  EPL_Hm0     Significant wave height  0.223597
                  Wind speed                    NaN
      F16_wind    Significant wave height       NaN
                  Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
                  Wind speed                    NaN
      HKNA_wind   Significant wave height       NaN
                  Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
                  Wind speed                    NaN
      c2_wind     Significant wave height       NaN
                  Wind speed               0.698317
SW_2  EPL_Hm0     Significant wave height  0.223597
                  Wind speed                    NaN
      F16_wind    Significant wave height       NaN
                  Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
                  Wind speed                    NaN
      HKNA_wind   Significant wave height       NaN
                  Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
                  Wind speed                    NaN
      c2_wind     Significant wave height       NaN
                  Wind speed               0.698317

@jsmariegaard
Copy link
Member Author

I am looking at the multivariable comparison, where not all combinations of model, observation and variable exist.

Does this behaviour make sense ,i.e selecting a list of columns or a single column?

In the first case with [["rmse"]] I don't get any missing values, whiile using ["rmse"] I do.

>>> s[["rmse"]].to_dataframe()
                                                rmse
model observation variable                         
SW_1  EPL_Hm0     Significant wave height  0.223597
      F16_wind    Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
      HKNA_wind   Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
      c2_wind     Wind speed               0.698317
SW_2  EPL_Hm0     Significant wave height  0.223597
      F16_wind    Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
      HKNA_wind   Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
      c2_wind     Wind speed               0.698317
>>> s["rmse"].to_dataframe()
                                               rmse
model observation variable                         
SW_1  EPL_Hm0     Significant wave height  0.223597
                  Wind speed                    NaN
      F16_wind    Significant wave height       NaN
                  Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
                  Wind speed                    NaN
      HKNA_wind   Significant wave height       NaN
                  Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
                  Wind speed                    NaN
      c2_wind     Significant wave height       NaN
                  Wind speed               0.698317
SW_2  EPL_Hm0     Significant wave height  0.223597
                  Wind speed                    NaN
      F16_wind    Significant wave height       NaN
                  Wind speed               2.775330
      HKNA_Hm0    Significant wave height  0.351964
                  Wind speed                    NaN
      HKNA_wind   Significant wave height       NaN
                  Wind speed               1.276179
      c2_Hm0      Significant wave height  0.378361
                  Wind speed                    NaN
      c2_wind     Significant wave height       NaN
                  Wind speed               0.698317

Nice catch - now fixed

@jsmariegaard jsmariegaard changed the title Replace SkillTable and SkillArray data containers with xarray Further improvements to SkillTable and SkillArray Dec 13, 2023
@ecomodeller ecomodeller merged commit 19d9990 into main Dec 13, 2023
@ecomodeller ecomodeller deleted the xarray-for-skill-class2 branch December 13, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants