Expose kwargs PR #299
Merged
Expose kwargs PR #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmariegaard
requested changes
Dec 4, 2023
|
Added test, had to refactor old test to get some more 'real' noisy data, since previous data was just a linear regression kind of. |
$ ruff .
tests/test_metrics.py:4:18: F401 [*] `pandas` imported but unused@daniel-caichac-DHI have you used |
Don't even know what this is |
Ruff is a new and very popular linter, which we now use for all of our projects. It checks your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, following @jsmariegaard recommendation, I just did a simple PR exposing some kwargs in the Peak Ratio, and will try to use custom metrics instead.