Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep user defined model name #244

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Keep user defined model name #244

merged 2 commits into from
Jul 6, 2023

Conversation

ecomodeller
Copy link
Member

No description provided.

@ecomodeller ecomodeller marked this pull request as ready for review July 5, 2023 19:27
@ecomodeller ecomodeller requested a review from jsmariegaard July 5, 2023 19:28
@@ -240,6 +240,10 @@ def _extract_from_models(obs, mod: List[protocols.ModelResult]) -> List[pd.DataF
mr = mr.extract(obs)

df = mr.data

# TODO is this robust enough?
old_item = df.columns.values[-1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it like this for now and then revisit when we allow arbitrary aux items

@jsmariegaard jsmariegaard merged commit c54d818 into main Jul 6, 2023
@jsmariegaard jsmariegaard deleted the track_model_name_compare branch July 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants