Kernel Density Estimation #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
😍 |
|
|
jsmariegaard
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
I love this addition. Thanks a lot.
A few comments though:
- I somehow like the "clean" plot, but I think it breaks the style of the other plots - and is not the same as you would get (and expect) from df.plot.kde() - on the other hand it is a bit hard to make use of numbers on the density axis if it was present...
- In the long run, I think all our plots should go in a "plotter" similar to pandas and mikeio, so the syntax would be cmp.plot.kde() and cmp.plot.hist() etc - but this should not be part of this PR
Agree on both😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A KDE plot is one of the best ways to compare multiple distributions.