Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added_z_comparison #204

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Added_z_comparison #204

merged 3 commits into from
Jun 23, 2023

Conversation

daniel-caichac-DHI
Copy link
Collaborator

When creating a point comparer object, the user can specify (if he wants) x,y,z, and by default they are none.
For some reason in the comparison objects, then the values of x,y where being inherited, (if None, None was being inherited) but z dissapeared, for no reason.
I just added z just like x and y

Added z  just like x,y
trying to pass the tests
Model does not necessarily have a 'z' value
@daniel-caichac-DHI
Copy link
Collaborator Author

I need it just for metadata

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - but I understand also that what you are actually after is the ability to carry forward arbitrary metadata

@jsmariegaard jsmariegaard merged commit 6cf680b into main Jun 23, 2023
@jsmariegaard jsmariegaard deleted the add_z_comparison branch June 23, 2023 17:43
@jsmariegaard jsmariegaard mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants