Comparer further refactoring #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmariegaard
reviewed
Apr 6, 2023
| self.data = matched_data | ||
| self.raw_mod_data = raw_mod_data | ||
| self.raw_mod_data = ( |
There was a problem hiding this comment.
Shouldn't raw_mod_data be None if not provided?
jsmariegaard
reviewed
Apr 6, 2023
| @@ -479,6 +479,20 @@ def __init__( | |||
| if not df.index.is_unique: | |||
| df.index = make_unique_index(df.index, offset_duplicates=offset_duplicates) | |||
|
|
|||
| # TODO is this needed elsewhere? | |||
There was a problem hiding this comment.
x_item and y_item should be parsed (and renamed) in the same way for track modelresults and track observations. But not necessarily the task of this PR.
jsmariegaard
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And data without a kind attribute are auxilliary variables.