Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning scatter plot #173

Merged
merged 1 commit into from
Mar 3, 2023
Merged

add warning scatter plot #173

merged 1 commit into from
Mar 3, 2023

Conversation

daniel-caichac-DHI
Copy link
Collaborator

Hi, I added a warning the following reasons

  • Usually when plotting a scatter plot with points, having 50k points is enough, and for larger datasets by default a sample of the dataset is plotted (as this is faster than plotting the complete dataset)
  • In most cases this is ok, but sometimes the user wants to see all points to identify the possible outliers, this was already possible with show_points=True , but sometimes the user (aka myself) forget about this.
  • I rarely have more than 50k points when comparing model/measurements, but when I do, I want to be reminded that the plot is just using a sample, so I added a warning that, if a sample of the total set is being plotted (despite the statistics being calculated on the total data set), will remind the user of this
  • For smaller datasets (<50k points) the total set is plotted and the warning is not triggered. Also if show_points=True or show_points=1.0 the warning is not triggered.

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea - looks good

@daniel-caichac-DHI daniel-caichac-DHI merged commit 2bf2ccd into main Mar 3, 2023
@jsmariegaard jsmariegaard deleted the scatter_plot_warning branch November 20, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants