Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelResult isolated refactor #170

Merged
merged 112 commits into from
Mar 16, 2023
Merged

ModelResult isolated refactor #170

merged 112 commits into from
Mar 16, 2023

Conversation

PaulDanielML
Copy link
Collaborator

No description provided.

jsmariegaard
jsmariegaard reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jsmariegaard
Copy link
Member

@PaulDanielML feel free to update from main when its fit you (it should have minimal consequences for your work)

PaulDanielML and others added 21 commits February 24, 2023 11:38
@PaulDanielML
first grid extraction, less nested file structure
c34f06c
@PaulDanielML
Merge branch 'main' into modelresult_refactor
0dcddc2
@PaulDanielML
cleanup & track_obs_from_xr_mr
ed6d7a1
@PaulDanielML
DfsuModelResult point extraction
87f8525
@PaulDanielML
DfsuModelResult track extraction
71a8b84
@PaulDanielML
factory
52f3e09
@PaulDanielML
further work on factory
ce83e9b
@PaulDanielML
comment out tests using old MR classes
2c0ba19
@PaulDanielML
removing mikeio.Dataset extraction for now
c530c3c
@PaulDanielML
added iteminfo
414805c
@PaulDanielML
Merge branch 'main' into modelresult_refactor
fbfb21c
@PaulDanielML
reintroduce extract_observation to keep previous API intact, not ideal
05215fb
@PaulDanielML
small modelresult test update
da8eaa9
@PaulDanielML
multi file .nc support, factory cleanup
7d661a7
@PaulDanielML
move extract_observation out of base class
71fb4bb
@PaulDanielML
pandas dataframe input support
9335f1a
@PaulDanielML
small fix on unbound variable
a8e88cb
@PaulDanielML
fix list type annotation, not supported by 3.8
d4102ad
@PaulDanielML
same for tuple
43d34a2
@jsmariegaard
simplify _parse_single_model
ab77935
@jsmariegaard
remove references to old types, disable validation, call extract if E…
2595448 
…xtractable, FM geometry
jsmariegaard and others added 24 commits March 15, 2023 08:30
@jsmariegaard
temp disable problematic line in notebook (fix later!)
01caae2
@jsmariegaard
remove unused
b5c791d
@ecomodeller
Flexible geometry guessing
d40e27c
@ecomodeller
Missing attributes
eaf9a02
@ecomodeller
Test bad geometry
f97c2a8
@ecomodeller
Tweak GeomType
00fc59c
@ecomodeller
Remove unused files
95a41b4
@ecomodeller
New variable
ce8b8a8
@ecomodeller
Hints for optional args
922a479
@ecomodeller
Optional args
a562b60
@ecomodeller
Comment unused method
f1abd48
@ecomodeller
Rename to match src
ad9341f
@jsmariegaard
rename geometry_type to gtype and move GeometryType Enum to types.py
61b7eb2
@jsmariegaard
move extract functions into relevant classes
5d42f4b
@jsmariegaard
Merge branch 'modelresult_refactor' of https://github.com/DHI/fmskill …
3ba49d9 
…into modelresult_refactor
@jsmariegaard
docstrings
d77353d
@jsmariegaard
removed extraction.py - in sourced in relevant classes
2787825
@jsmariegaard
docstring
8fde714
@jsmariegaard
dosctring and types.TrackType
6869adc
@jsmariegaard
move _validate_any_obs_in_model_time to base
891922b
@jsmariegaard
Merge branch 'main' into modelresult_refactor
3b39b6c
@jsmariegaard
remove unused
ba1343f
@jsmariegaard
document new ModelResult classes
ee299af
@jsmariegaard
check if DfsuModelResult before plotting domain boundary
95e748a
@jsmariegaard
Copy link
Member

@ecomodeller I think we're done here. Do you agree?

@jsmariegaard jsmariegaard merged commit 3cc28d0 into main Mar 16, 2023
@jsmariegaard jsmariegaard deleted the modelresult_refactor branch March 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecomodeller ecomodeller ecomodeller approved these changes

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulDanielML @jsmariegaard @ecomodeller