Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Skill Table if N_obs>1 #151

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Added Skill Table if N_obs>1 #151

merged 2 commits into from
Dec 22, 2022

Conversation

daniel-caichac-DHI
Copy link
Collaborator

@daniel-caichac-DHI daniel-caichac-DHI commented Dec 20, 2022

Hi,

I just did a very small change as before plotting a scatter with skill_table was only allowed for 1 observation vs the model.
Now it works for n number of observations with n>=1 , and in this case the skill_table will be cc.mean_skill()

Example of skill table with 1 observation

image

Example of skill table with n>1 observations

image

This is a very powerful tool of fmskill (the mean_skill) and I changed nothing in it, just added the option to put it in a scatter plot.

@daniel-caichac-DHI daniel-caichac-DHI marked this pull request as ready for review December 20, 2022 13:21
@daniel-caichac-DHI
Copy link
Collaborator Author

daniel-caichac-DHI commented Dec 20, 2022

Fixed a bug when the skill_table was being requested for a Pointcomparer (it used to work just for ComparerCollection, now it works for both).
I fixed it because it failed some tests

@jsmariegaard jsmariegaard merged commit ef0aeb9 into main Dec 22, 2022
@jsmariegaard jsmariegaard deleted the skill_table_many_obs branch December 22, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants